PennMUSH Community

Ticket #5883 (closed suggested feature: fixed)

Opened 5 years ago

Last modified 2 years ago

SIGUSR1/SIGALRM Logging

Reported by: anonymous Assigned to: raevnos
Priority: minor Milestone: 1.8.2p4
Keywords: Cc:
Visibility: Public

Description (Last modified by raevnos)

Hey. Yeah. I realized that receipt of SIGHUP is logged, but SIGUSR1 and
SIGALRM aren't. Javelin and I had a brief conversation, and he mentioned
that you can tell where SIGUSR1 was received by finding the reboot...
but I don't think that's as secure as it should be. I think SIGUSR1
(and SIGALRM) should be logged to the same log (LT_ERR) as SIGHUP.
I modified timer.c to do this for SIGUSR1, and diff reports my changes
as

106a107
>	do_rawlog(LT_ERR, T("SIGUSR1 received: rebooting"));


This is 1.7.6p11, 06 02 2003, 19:30 EST.
I didn't do one for SIGALRM as there doesn't appear to be as appropriate
a place for it in the hardcode. I definitely think it should be logged,
but where?

Change History

06/03/03 00:06:50 changed by Shawn Wagner <shawnw@speakeasy.org>

On Mon, Jun 02, 2003 at 06:04:56PM -0500, interloper@dbox.wox.org wrote:
> Hey. Yeah. I realized that receipt of SIGHUP is logged, but SIGUSR1 and
> SIGALRM aren't. Javelin and I had a brief conversation, and he mentioned
> that you can tell where SIGUSR1 was received by finding the reboot...
> but I don't think that's as secure as it should be. I think SIGUSR1
> (and SIGALRM) should be logged to the same log (LT_ERR) as SIGHUP.
> I modified timer.c to do this for SIGUSR1, and diff reports my changes
> as
> 
> 106a107
> >	do_rawlog(LT_ERR, T("SIGUSR1 received: rebooting"));
> 
> 
> This is 1.7.6p11, 06 02 2003, 19:30 EST.
> I didn't do one for SIGALRM as there doesn't appear to be as appropriate
> a place for it in the hardcode. I definitely think it should be logged,
> but where?

Why should it be logged? We don't listen for SIGALARM anywhere. 

HUP, USR1, USR2, TERM... I think those are the important ones that need to
be logged.

-- 
Shawn Wagner
shawnw@speakeasy.org

05/01/07 13:10:46 changed by raevnos

  • owner changed from devteam to raevnos.
  • description changed.
  • milestone set to 1.8.2p4.

05/01/07 13:17:08 changed by raevnos

  • status changed from new to closed.
  • resolution set to fixed.