PennMUSH Community

Ticket #6638 (closed bug: fixed)

Opened 4 years ago

Last modified 2 years ago

BUG Attribute Trees and Empty Attributes

Reported by: anonymous Assigned to: devteam
Priority: major Milestone: 1.8.2p4
Keywords: Cc:
Visibility: Public

Description (Last modified by raevnos) 

I was working with Empty Attributes turned on and Attribute Trees and 
all was kosher.  Of course, I had a few outer layers that had no values 
set to them.  I'm working on some code that's supposed to be 
cross-platform compatible so I went in and turned Empty Attributes back 
off and lo and behold .... it cleared out those outer layer trees. :)  
lattr() no longer functioned on the inner layers of the tree until I'd 
completely rebuilt the tree.  Fun little toy.  Enjoy!

KK

Change History

03/25/07 14:27:20 changed by raevnos

  • priority changed from minor to major.
  • description changed.
  • milestone set to 1.8.2p4.

As of 1.8.2, turning off empty_attrs will not cause empty root attributes to be deleted, EXCEPT in the following case: Change empty_attrs in mush.cnf, and do a reboot.

In that case, atr_new_add() will skip empty attributes, and later when adding the leaf attributes, it doesn't do the checks that atr_add() does to make sure there's a root.

Three possible solutions:

* Remove the empty attribute check. A database created under empty_attrs=yes will load the same way under empty_attrs=no, but the only new empty attributes that can be created are those automatically created root attributes.

0

* Add the missing-root check: More work for what's supposed to be a simple special-case function.

-1

* Have root attributes indicated by an actual attribute flag, and allow those to be set when empty.

+1

05/05/07 23:16:48 changed by raevnos

  • status changed from new to closed.
  • resolution set to fixed.