PennMUSH Community

Ticket #7176 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

configs

Reported by: anonymous Assigned to: devteam
Priority: minor Milestone: 1.8.2p4
Keywords: Cc:
Visibility: Public

Description

config() returns two invalid config options (invalid meaning
'mis-presented').

max_player_channels should be max_player_chans

tiny_trim_func should be tiny_trim_fun

Attachments

part0001.html (199 bytes) - added by Chuc McGuire on 01/20/07 04:04:38.
part0001.2.html (2.4 kB) - added by Chuc McGuire on 01/20/07 14:28:47.

Change History

01/20/07 04:04:38 changed by Chuc McGuire

  • attachment part0001.html added.

01/20/07 04:04:38 changed by Chuc McGuire

  • id set to 7176.

This message has 1 attachment(s)

01/20/07 14:25:13 changed by Talvo

Those are actually the wrong way around (probably my fault for explaining badly) - config() gives the right names, but in the help (help @config tiny, and help @config chan, I think) the names are shown incorrectly.

01/20/07 14:28:47 changed by Chuc McGuire

  • attachment part0001.2.html added.

(follow-up: ↓ 4 ) 01/20/07 14:28:47 changed by Chuc McGuire

Actually... I wrote this from doing...

think iter(config(),ljust(%i0,26) config(%i0),%b,%r)

and describing the results.

config() does actually generate wrong names.

On 1/20/07, Penndev <pennmush-bugs@pennmush.org> wrote:
>
> #7176: configs
>
> ---------------------------------------------------+------------------------
>   Reporter:  "Chuc McGuire" <nemosolid@gmail.com>  |       Owner:  devteam
>       Type:  incoming                              |      Status:  new
>   Priority:  minor                                 |   Milestone:
> Resolution:                                        |    Keywords:
> Visibility:  Public                                |
>
> ---------------------------------------------------+------------------------
> Comment (by Talvo):
>
> Those are actually the wrong way around (probably my fault for explaining
> badly) - config() gives the right names, but in the help (help @config
> tiny, and help @config chan, I think) the names are shown incorrectly.
>
> --
> Ticket URL: <http://dev.pennmush.org/ticket/7176#comment:2>
> Penndev <http://www.pennmush.org/dev/>
> PennMUSH Development
>

(in reply to: ↑ 3 ) 01/20/07 14:52:27 changed by Talvo

Replying to Chuc McGuire:

Hrm, strange. config() reports both of those fine (as max_player_chans and tiny_trim_fun) on my test game (1.8.1p9). Can't connect to M*U*S*H atm to try it there, though, it seems to be down. It's only the help-files where I see a problem for those two.

01/20/07 15:28:51 changed by ehearn

  • status changed from new to closed.
  • type changed from incoming to bug.
  • resolution set to fixed.
  • milestone set to 1.8.2p2.

01/21/07 16:08:14 changed by ray73864

  • status changed from closed to reopened.
  • resolution deleted.

I just tried this piece of code, and it was more than just those 2 that came up as errors.

I am using Penn 1.8.2p1, and the following came up as errors:

  • sql_username
  • sql_password
  • sql_database
  • max_global_fns
  • log_wipe_passwd

However, 'max_player_chans' and 'tiny_trim_fun' were indeed spelt correctly and produced no error.

And yes, SQL is defined on my game.

01/21/07 16:30:02 changed by ehearn

  • status changed from reopened to closed.
  • resolution set to fixed.

The SQL and log_wipe data is filtered out for security reasons and it is unlikely this will be changed.

The max_global_fns option returns an error because it is not in a category. Since there seems to be no serious security concerns regarding it, I'll place it in the limits category.

01/21/07 18:29:49 changed by Talvo

  • status changed from closed to reopened.
  • resolution deleted.

There's a comment in mush.cnf that says you should @shutdown/reboot immediately after changing max_global_fns, and it looks like it only allocates enough memory on restart for however many @functions the option is set to - so increasing it in-game and adding more than the original setting's worth of @functions would probably crash the MUSH?

WRT the config options ray mentioned.. Maybe it would be better if config() didn't list options which you can't see the values of from inside the MUSH/which aren't in a category (I think those two facts are one and the same)?

01/27/07 00:15:22 changed by ehearn

  • milestone deleted.

It may be worth considering a change in the config() code to have it exclude those options that can't be viewed with it in any case. This is something for some point in the future.

04/24/07 17:12:31 changed by raevnos

  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone set to 1.8.2p4.

config() no longer lists items with an empty group. Also fixed a buglet where there was an extra space at the end of the returned list.