PennMUSH Community

Ticket #7189 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

PUBLIC: Page escaped = fix

Reported by: anonymous Assigned to: raevnos
Priority: minor Milestone: 1.8.2p4
Keywords: Cc:
Visibility: Public

Description 

Right now, cmd_page treats
  
  page foo\=bar

as an attempt to page the player "foo=bar" with nothing.

This is surprising, and not even remotely useful, since players can't be
named "foo=bar".

The patch fixes cmd_page to treat that as paging the last-paged player
with "foo\=bar". This is less surprising, potentially useful, and
consistant with the behaviour of other eqsplit commands, e.g.

  @switch foo=bar=foo=bar, think Match., think No match.
  No match.

  @switch foo\=bar=foo=bar, think Match., think No match.
  Match.

Attachments

page-escaping-fix.patch.txt (0.7 kB) - added by Nathan Baum on 01/30/07 18:37:28.

Change History

01/30/07 18:37:28 changed by Nathan Baum

  • attachment page-escaping-fix.patch.txt added.

01/30/07 18:37:28 changed by Nathan Baum

  • id set to 7189.

This message has 1 attachment(s)

(in reply to: ↑ description ) 02/03/07 19:08:34 changed by Nathan Baum

This patch makes the page test fail. More generally, a trailing = is effectively ignored, so "page bob=" is interpreted as "page bob". This probably isn't what anyone wants, and isn't what happens at the moment.

Looking for an easy fix, I noticed that the command parser already makes the existence of a right-hand-side known via the rhs_present variable.

Removing the has_eq variable and replacing the reference to it in do_page with rhs_present keeps the expected behaviour of a trailing = but still also makes escaped =s work as expected.

04/24/07 16:00:14 changed by raevnos

  • owner changed from devteam to raevnos.
  • type changed from incoming to bug.
  • milestone set to 1.8.2p4.

05/01/07 12:43:31 changed by raevnos

  • status changed from new to closed.
  • resolution set to fixed.