PennMUSH Community

Ticket #7397 (closed bug: fixed)

Opened 1 year ago

Last modified 1 year ago

Bug in default attribute flags

Reported by: Talvo Assigned to: devteam
Priority: minor Milestone: 1.8.3p4
Keywords: Cc: talvo@talvo.com
Visibility: Public

Description

Hey,

(Hopefully this'll get through OK - can't see the New Ticket link on the 
dev.pennmush.org site atm.)

There seems to be a bug in Penn 1.8.3p1 and greater when setting standard 
attributes via ATTRIB_SET (&attr, @attr or @_attr). It doesn't happen when 
the command is typed from a client, but does when a Thing is @forced to set 
the attribute. Instead of getting the flags defined via @attribute, it just 
gets set no_command. The problem seems to be that set_default_flags in 
attrib.c was changed so that the flags passed as it's second arg take 
precedence over the standard attr flags (and it seems that it gets passed 
no_command when an attr is set with ATTRIB_SET any way but from the socket). 
I can't see that change mentioned in the changelogs, so I'm not sure why it 
happened, but it seems it should either be reversed, or changed so it gets 
both the standard flags and those passed to set_default_flags.

Hope that makes some sense. Probably shouldn't send these so late at night 
;p
Mike
This was found by Whiskey@M*U*S*H, btw, I just helped him debug why it was 
happening. 

Change History

(in reply to: ↑ description ) 06/28/07 09:38:07 changed by raevnos

  • type changed from incoming to bug.
  • milestone set to 1.8.3p4.

Replying to Talvo:

(Hopefully this'll get through OK - can't see the New Ticket link on the dev.pennmush.org site atm.)

You have to create a trac account and log in; anonymous ticket creation was disabled because of excessive spamming.

07/07/07 19:37:14 changed by raevnos

I'm trying something that ors together default flags and specified ones. I still need to go through and make sure that that flags argument is only ever used with NO_COMMAND before checking it in.

07/15/07 11:31:54 changed by raevnos

  • status changed from new to closed.
  • resolution set to fixed.